Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Change adapter image into temp ACR registry #503

Closed
wants to merge 1 commit into from
Closed

chore: Change adapter image into temp ACR registry #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/e2e-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ jobs:
run: |
make docker-build-adapter
env:
REGISTRY: ${{ env.REGISTRY }}
REGISTRY: ${{ env.CLUSTER_NAME }}.azurecr.io
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this is working unchanged for e2e tests outside of publish-gh-image.yaml


- name: create cluster
shell: bash
Expand Down Expand Up @@ -211,6 +211,7 @@ jobs:
REGISTRY: ${{ env.REGISTRY }}
AI_MODELS_REGISTRY: ${{ secrets.E2E_ACR_AMRT_USERNAME }}.azurecr.io
AI_MODELS_REGISTRY_SECRET: ${{ secrets.E2E_AMRT_SECRET_NAME }}
ADAPTER_REGISTRY: ${{ env.CLUSTER_NAME }}.azurecr.io

- name: Cleanup e2e resources
if: ${{ always() }}
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/inference_with_adapters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
var DefaultStrength = "1.0"

var imageName = "e2e-adapter"
var fullImageName = utils.GetEnv("REGISTRY") + "/" + imageName + ":0.0.1"
var fullImageName = utils.GetEnv("ADAPTER_REGISTRY") + "/" + imageName + ":0.0.1"

var validAdapters = []kaitov1alpha1.AdapterSpec{
{
Expand Down
Loading