New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bicep changes #45

Merged

jfaurskov merged 9 commits into main from bicep-changes

Dec 12, 2023

Contributor

bakrish commented Nov 30, 2023

Multiple changes have been incorporated:

Updates to each resource module to include AVM components
A Common types file - containing type definitions for most parameters and variables
Bicep param files for Single instance and data guard
Bicep config json file - with experimental features enabled .

bakrish and others added 7 commits

October 25, 2023 16:55


          bicep-initial

b183813


          Add array changes

e1a8496


          Remove modules replaced by AVM modules

5bacb0f


          Added Data Guard configuration, additional fixes for idempotency and …

2e0d583

…other issues


          Added Data guard Configuration, and additional fixes for idempotency …

50c523f

…and AVM-related changes


          More bugfixes and changes , and description

f0fa3e8


          Doc changes

51c439b

bakrish requested a review from jfaurskov

November 30, 2023 09:39

github-actions bot commented Nov 30, 2023

Terraform Initialization ⚙️`success`

Terraform Validation 🤖`success`

Terraform Plan 📖`success`

Pusher: @bakrish, Action: pull_request, Workflow: Deploy Single Instance Oracle DB on Azure

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/default/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/default/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/default/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/default/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/default/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/README.md Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/data_guard/diagnostics/data_guard.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/single_instance/default/single_instance.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/single_instance/default/single_instance.bicepparam Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/single_instance/diagnostics/README.md Outdated Show resolved Hide resolved

jfaurskov reviewed

View reviewed changes

bicep/bootstrap/single_instance/diagnostics/single_instance.bicepparam Outdated Show resolved Hide resolved

jfaurskov requested changes

View reviewed changes

Collaborator

jfaurskov left a comment

Awesome work @bakrish, I have a number of general comments, but this is truly impressive. :-)

bakrish added 2 commits

December 11, 2023 16:28


          Fixes for review comments

27f3691


          Changed workspace ID, updated adminUserName to Oracle

a43e816

jfaurskov self-requested a review

December 12, 2023 13:45

jfaurskov approved these changes

View reviewed changes

Collaborator

jfaurskov left a comment

LGTM

jfaurskov merged commit 0b48ac2 into main

1 check passed

jfaurskov deleted the bicep-changes branch

February 27, 2024 09:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet