Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable telemetry #46

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Enable telemetry #46

merged 4 commits into from
Dec 6, 2023

Conversation

jfaurskov
Copy link
Collaborator

Description

Enable telemetry for terraform deployments. Update docs and terraform code so that an (otherwise empty) ARM deployment with a unique GUID is deployed to subscription if disable_telemetry is left at default value (false). If value is set to true deployment is either not run or if it exists it is destroyed as per Terraforms normal MO.

Changes

  1. Updated manual deployment guide with correct syntax for generating fixtures.tfvars
  2. Updated broken links introduction to deploying guide
  3. Updated telemetry doc with correct information
  4. Added assorted TF code to include deployment.

@kohei3110 / @sihbher could either of you please review and also make sure that the telemetry bits make sense?

Copy link

github-actions bot commented Dec 5, 2023

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Terraform Plan 📖success

Pusher: @jfaurskov, Action: pull_request, Workflow: Deploy Single Instance Oracle DB on Azure

Copy link
Contributor

@kohei3110 kohei3110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I tried to deploy these architectures and could deploy as expected.

@kohei3110 kohei3110 merged commit f857229 into main Dec 6, 2023
3 checks passed
@jfaurskov jfaurskov deleted the enable-telemetry branch February 27, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants