Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right Click Draft Validate #1123

Merged
merged 10 commits into from
Dec 20, 2024
Merged

Right Click Draft Validate #1123

merged 10 commits into from
Dec 20, 2024

Conversation

ReinierCC
Copy link
Collaborator

Webview implementation to output draft validate.

Open to any suggestions for naming, extra text or styling.

image

Screenshot 2024-12-12 at 12 20 14 PM

Huge thanks to @tbarnes94 and @Tatsinnit

@ReinierCC ReinierCC added enhancement 🚀 New feature or request or improvements on existing code. DRAFT tool integration 🤹‍♀️ labels Dec 12, 2024
@ReinierCC ReinierCC self-assigned this Dec 12, 2024
@ReinierCC
Copy link
Collaborator Author

VSIX for testing (rename and remove ".zip"):
vscode-aks-tools-1.5.2-draft-validate.vsix.zip

Tatsinnit
Tatsinnit previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thank you so much for sharing this v0 —it looks great to me. I think it also works well for the audience. As they’ll be able to see a few of my initial commits. If possible, let’s get feedback from @tejhan, @hsubramanianaks, or @qpetraroia as well.

Looks cleaner v0 to me. Thanks heaps.

src/webview-contract/webviewDefinitions/draft/draftValidate.ts Outdated Show resolved Hide resolved
src/panels/draft/DraftValidatePanel.ts Show resolved Hide resolved
@tbarnes94
Copy link
Member

thank you for adding the workspace name to the tabs! should help a lot with multiple runs. LGTM!

hsubramanianaks
hsubramanianaks approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@hsubramanianaks hsubramanianaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, @ReinierCC one question - is draft validate option included in draft binaries that is downloaded or needs a version bump for draft binaries ?

@Tatsinnit
Copy link
Member

looks good, @ReinierCC one question - is draft validate option included in draft binaries that is downloaded or needs a version bump for draft binaries ?

💡I can try and reply and Reinier can confirm, validate is used as per whatever the current binary version is. ❤️🙏☕️

@ReinierCC ReinierCC merged commit cc2e4e4 into Azure:main Dec 20, 2024
8 checks passed
@ReinierCC
Copy link
Collaborator Author

Current draft binary version works well

@Tatsinnit Tatsinnit mentioned this pull request Dec 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tatsinnit Tatsinnit Tatsinnit approved these changes

@hsubramanianaks hsubramanianaks hsubramanianaks approved these changes

@tbarnes94 tbarnes94 tbarnes94 approved these changes

@qpetraroia qpetraroia Awaiting requested review from qpetraroia

Assignees

@ReinierCC ReinierCC

Labels
DRAFT tool integration 🤹‍♀️ enhancement 🚀 New feature or request or improvements on existing code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ReinierCC @tbarnes94 @Tatsinnit @hsubramanianaks