Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding API calls to create a Fleet #1160

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

JunyuQian
Copy link
Contributor

This is the initial pull request, implementing the API call for fleet creation and the callback function triggered by the user’s right-click on the ‘Create Fleet’ button.

The entry point (the ‘Create Fleet’ button) for this function is not yet available in the UI. This ensures that users will not encounter features still under development, enabling seamless and incremental integrations.

@Tatsinnit
Copy link
Member

💡 🥷 Note only please: (for help for broken build) Build is broken because the package @azure/arm-containerservicefleet is missing from the package.json please add it and it will work magically :) (obviously under the hood it will find the package from package manager)

Screenshot 2025-01-08 at 12 37 21 PM

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Tatsinnit Tatsinnit added enhancement 🚀 New feature or request or improvements on existing code. Incremental Build 🏗️ labels Jan 8, 2025
@JunyuQian
Copy link
Contributor Author

Hi @Tatsinnit @serbrech @dvadas, thank you all for your comments! All the problems have been addressed and please let me know if there is anything I can improve :)

Tatsinnit
Tatsinnit previously approved these changes Jan 8, 2025
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 ❤️ Looks good to me, this is skeleton only PR, nothing is hooked yet for the work under create fleet idea of integration to VSC.

@ReinierCC
Copy link
Collaborator

ReinierCC commented Jan 8, 2025

Good work so far! It looks like your commits are unsigned so you might have some difficulty when you go to merge your PR.

You'll likely need to generate a new GPG key and resign your commits.

I dealt with this same issue recently, so if you have any questions feel free to reach out!

@Tatsinnit
Copy link
Member

Good work so far! It looks like your commits are unsigned so you might have some difficulty when you go to merge your PR.

You'll likely need to generate a new GPG key and resign your commits.

I dealt with this same issue recently, so if you have any questions feel free to reach out!

❤️ Thank you so much @ReinierCC , nice catch, yes please lets get your commit signed @JunyuQian

Here are few docs as to how to sign your commits.

Please feel free to reach out if you get stuck,

Just as example by verification all your commit will have this verified tag

Screenshot 2025-01-09 at 11 43 39 AM

Thanks heaps.

Tatsinnit
Tatsinnit previously approved these changes Jan 9, 2025
adding library dependencies

hide right-click button

removing irrelevant code and adding comments

fixing typo and adding signature

Signed-off-by: Tatsat Mishra <[email protected]>

adding library dependencies

hide right-click button

removing irrelevant code and adding comments
@Tatsinnit Tatsinnit merged commit 833d589 into Azure:main Jan 9, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request or improvements on existing code. Incremental Build 🏗️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants