-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding API calls to create a Fleet #1160
Conversation
Hi @Tatsinnit @serbrech @dvadas, thank you all for your comments! All the problems have been addressed and please let me know if there is anything I can improve :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work so far! It looks like your commits are unsigned so you might have some difficulty when you go to merge your PR. You'll likely need to generate a new GPG key and resign your commits. I dealt with this same issue recently, so if you have any questions feel free to reach out! |
❤️ Thank you so much @ReinierCC , nice catch, yes please lets get your commit signed @JunyuQian Here are few docs as to how to sign your commits.
Please feel free to reach out if you get stuck, Just as example by verification all your commit will have this Thanks heaps. |
adding library dependencies hide right-click button removing irrelevant code and adding comments fixing typo and adding signature Signed-off-by: Tatsat Mishra <[email protected]> adding library dependencies hide right-click button removing irrelevant code and adding comments
2ba4a2f
to
b2312da
Compare
This is the initial pull request, implementing the API call for fleet creation and the callback function triggered by the user’s right-click on the ‘Create Fleet’ button.
The entry point (the ‘Create Fleet’ button) for this function is not yet available in the UI. This ensures that users will not encounter features still under development, enabling seamless and incremental integrations.