-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate webapps-deploy to OneDeploy #360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannysongg
requested review from
kaverma,
kanika1894 and
BALAGA-GAYATRI
as code owners
September 1, 2023 01:53
dannysongg
had a problem deploying
to
automation test
September 1, 2023 01:53
— with
GitHub Actions
Failure
dannysongg
had a problem deploying
to
automation test
September 1, 2023 01:53
— with
GitHub Actions
Failure
This PR is idle because it has been open for 14 days with no activity. |
dannysongg
had a problem deploying
to
automation test
September 22, 2023 21:13
— with
GitHub Actions
Failure
jvano
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
dannysongg
had a problem deploying
to
automation test
September 28, 2023 19:56
— with
GitHub Actions
Failure
dannysongg
had a problem deploying
to
automation test
September 28, 2023 19:56
— with
GitHub Actions
Failure
dannysongg
had a problem deploying
to
automation test
September 28, 2023 19:57
— with
GitHub Actions
Failure
dannysongg
had a problem deploying
to
automation test
September 28, 2023 19:57
— with
GitHub Actions
Failure
dannysongg
had a problem deploying
to
automation test
October 5, 2023 21:08
— with
GitHub Actions
Failure
dannysongg
had a problem deploying
to
automation test
October 5, 2023 21:08
— with
GitHub Actions
Failure
dannysongg
temporarily deployed
to
automation test
October 5, 2023 21:15
— with
GitHub Actions
Inactive
dannysongg
temporarily deployed
to
automation test
October 5, 2023 21:15
— with
GitHub Actions
Inactive
sgollapudi77
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The changes in this PR are dependent on the following PR getting merged and released: microsoft/pipelines-appservice-lib#99. It contains the changes to the Kudu service library that webapps-deploy consumes.
This change is to move the webapps-deploy Github Action to the new OneDeploy API. It is designed to be backwards compatible with webapps-deploy@v2. Regardless, this should be released as webapps-deploy@v3 to ensure that no existing users are regressed. Usage of the new action will look something like this:
The onedeploy-test branch in my fork has the required node_modules and can be used to test these changes before the piplines-appservice-lib PR gets merged. The test build can be invoked with: