Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenidConnectMessage serializes as 6x #2351

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

brentschmaltz
Copy link
Member

There were a few customers who had issues with the deserialization of the OpenidConnectMessage, particularly with numbers.
The serialization has been adjusted to match 6.x for simple types.

There is one slight change with complex types (Arrays and Objects), 6x would deserialize with formatting (\r, \n, and spaces.) 7x does not have any formatting.

A test was added to ensure the reading from Google and AAD discovery endpoints is successful.

Fixes #2336

Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19 jennyf19 added this to the 7.0.3 milestone Oct 6, 2023
@brentschmaltz brentschmaltz merged commit c1a63dd into dev Oct 6, 2023
4 checks passed
@brentschmaltz brentschmaltz deleted the brentsch/OidcSerialize branch October 6, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] OpenIdConnectMessage Improperly Parses expires_in Field
2 participants