Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add Eddsa signature validation algorithms. fix #2426 #2427

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

wparad
Copy link

@wparad wparad commented Dec 15, 2023

Add Eddsa signature validation algorithms. fix #2426

Add in EdDSA almost everywhere. Still missing:

  • Code to actually verify EdDSA algorithm along with the generation of the EdDSASecurity key class.

At this point, I'm looking for encouragement to continue this PR.

Thanks,
Warren

@wparad
Copy link
Author

wparad commented Dec 15, 2023

@microsoft-github-policy-service agree company="Rhosys AG"

@brentschmaltz
Copy link
Member

@wparad we are discussing this internally.
Will have an answer soon.

Copy link
Member

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to see test cases for all the additional algorithms.
It would be best to create a new file for theses tests.

@wparad
Copy link
Author

wparad commented Jun 13, 2024

@brentschmaltz Not just the unit tests, the code for the implementation is missing. Can you give me some pointers on where to write that implementation. It's very hard to understand a lot of the nomenclature that is being used here.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support EdDSA signature validations
2 participants