Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add base methods to tokenhandler #2630

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

add base methods to tokenhandler #2630

wants to merge 3 commits into from

Conversation

westin-m
Copy link
Contributor

@westin-m westin-m commented Jun 12, 2024 •
edited
Loading

Introduce additional base methods to TokenHandler.

@westin-m westin-m linked an issue Jun 12, 2024 that may be closed by this pull request
Consider adding more base methods to TokenHandler #1259
Open
@westin-m westin-m changed the title add base methods add base methods to tokenhandler Jun 12, 2024
@westin-m westin-m marked this pull request as ready for review June 12, 2024 21:25
@westin-m westin-m requested a review from a team as a code owner June 12, 2024 21:25
@westin-m westin-m marked this pull request as draft June 12, 2024 22:00
brentschmaltz
brentschmaltz requested changes Jun 13, 2024
View reviewed changes
Copy link
Member

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TokenType should be abstract.

@westin-m westin-m marked this pull request as ready for review June 14, 2024 19:31
@keegan-caruso
Copy link
Contributor

Why did we remove TokenType?

@westin-m
Copy link
Contributor Author

Why did we remove TokenType?

TokenType isn't moving from SecurityTokenHandler. That would need to happen in 8.x

@westin-m westin-m marked this pull request as draft August 6, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keegan-caruso keegan-caruso keegan-caruso left review comments

@FuPingFranco FuPingFranco FuPingFranco left review comments

@brentschmaltz brentschmaltz brentschmaltz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding more base methods to TokenHandler
4 participants
@westin-m @keegan-caruso @brentschmaltz @FuPingFranco