Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression tests: Added inner exception detail and invalid signature failure due to invalid algorithm used #2811

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Sep 5, 2024

Regression tests: Added inner exception detail and invalid signature failure due to invalid algorithm used

  • Added inner exception detail to provide inner exceptions without allocating them ahead of time
  • Wrap invalid algorithm validation error inside an invalid signature validation error to match the existing path
  • Added test case comparing the invalid algorithm on the signature validation error

Part of #2711

@iNinja iNinja requested a review from a team as a code owner September 5, 2024 14:07
Copy link
Contributor

@FuPingFranco FuPingFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iNinja iNinja merged commit 957ed51 into dev Sep 6, 2024
6 checks passed
@iNinja iNinja deleted the iinglese/regression-tests-inner-exceptiondetail branch November 15, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants