Use new Base64Url API

[msbw2]

Use the new Base64Url API.

[keegan-caruso]

@msbw2 Can you post a before / after of this benchmark as well here: JsonWebTokenHandler_ValidateTokenAsyncWithTVP ?

Would be good to see the difference at that level.

[pmaytak]

@msbw2 Can you post a before / after of this benchmark as well here: JsonWebTokenHandler_ValidateTokenAsyncWithTVP ?

Would be good to see the difference at that level.

Benchmarks are here: #2828 (comment)

[jennyf19]

[pmaytak]

Coverage is good

Base64UrlEncoder at 89% Base64UrlEncoding at 82%

https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1366079&view=codecoverage-tab

Should the test coverage be 100%? Curious what's not covered.

[Copilot]

Copilot reviewed 5 out of 10 changed files in this pull request and generated 1 comment.

Files not reviewed (5)

• build/dependencies.props: Language not supported
• src/Microsoft.IdentityModel.Tokens/InternalAPI.Unshipped.txt: Language not supported
• src/Microsoft.IdentityModel.Tokens/Microsoft.IdentityModel.Tokens.csproj: Language not supported
• src/Microsoft.IdentityModel.Tokens/LogMessages.cs: Evaluated as low risk
• src/Microsoft.IdentityModel.Tokens/Base64UrlEncoding.cs: Evaluated as low risk

Comments suppressed due to low confidence (3)

test/Microsoft.IdentityModel.Tokens.Tests/Base64UrlEncodingTests.cs:37

• [nitpick] The variable name 'randomPadding' is misleading as it is a constant string. Consider renaming it to 'paddingString'.

const string randomPadding = "RANDOMPADDING";

benchmark/Microsoft.IdentityModel.Benchmarks/Base64UrlEncoderTests.cs:20

• [nitpick] The variable name base64NoSpecialCharsEncodedString is quite long and could be confusing. Consider renaming it to something shorter and more descriptive.

private static readonly string base64NoSpecialCharsEncodedString = base64UrlEncodedString.Replace('-', 'A').Replace('_', 'B') + "ab";

benchmark/Microsoft.IdentityModel.Benchmarks/Base64UrlEncoderTests.cs:22

• [nitpick] The variable name base64NoSpecialCharsExceptPaddingEncodedString is quite long and could be confusing. Consider renaming it to something shorter and more descriptive.

private static readonly string base64NoSpecialCharsExceptPaddingEncodedString = base64UrlEncodedString.Replace('-', 'A').Replace('_', 'B') + "==";

[github-actions]

Summary

Summary

Generated on:	1/6/2025 - 7:53:42 PM
Coverage date:	1/6/2025 - 7:44:34 PM - 1/6/2025 - 7:53:13 PM
Parser:	MultiReport (60x Cobertura)
Assemblies:	1
Classes:	7
Files:	2
Line coverage:	80.3% (620 of 772)
Covered lines:	620
Uncovered lines:	152
Coverable lines:	772
Total lines:	483
Branch coverage:	67.8% (228 of 336)
Covered branches:	228
Total branches:	336
Method coverage:	Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%

Name	Line	Branch
Microsoft.IdentityModel.JsonWebTokens	80.3%	67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities	100%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0	81.4%	67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0	81.4%	67.6%