Dispose object in JsonWebTokenHandler.CreateToken.cs #3064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var kwp = key.CryptoProviderFactory.CreateKeyWrapProviderForUnwrap(); 'kwp' becomes out of scope and is not disposed.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
pmaytak
requested changes
Dec 28, 2024
| @@ -1365,15 +1365,15 @@ internal IEnumerable<SecurityKey> GetContentEncryptionKeys(JsonWebToken jwtToken | |||
| jwtToken.TryGetHeaderValue(JwtHeaderParameterNames.Apu, out string apu); | |||
| jwtToken.TryGetHeaderValue(JwtHeaderParameterNames.Apv, out string apv); | |||
| SecurityKey kdf = ecdhKeyExchangeProvider.GenerateKdf(apu, apv); | |||
| var kwp = key.CryptoProviderFactory.CreateKeyWrapProviderForUnwrap(kdf, ecdhKeyExchangeProvider.GetEncryptionAlgorithm()); | |||
| using var kwp = key.CryptoProviderFactory.CreateKeyWrapProviderForUnwrap(kdf, ecdhKeyExchangeProvider.GetEncryptionAlgorithm()); | |||
There was a problem hiding this comment.
I don't think this is the right change - we shouldn't dispose here.
CryptoProviderFactory.CreateKeyWrapProviderForUnwrap ends up calling CustomCryptoProvider.Create if it was set. CustomCryptoProvider implements ICryptoProvider which has a Create and a Release. So the interface intends for the creator to release the provider.
The more appropriate change would probably be to call CryptoProviderFactory.ReleaseKeyWrapProvider maybe in the finally.
gparametr
pushed a commit
to gparametr/azure-activedirectory-identitymodel-extensions-for-dotnet
that referenced
this pull request
Jan 10, 2025
Base on comments from: AzureAD#3064
gparametr
added a commit
to gparametr/azure-activedirectory-identitymodel-extensions-for-dotnet
that referenced
this pull request
Jan 10, 2025
Based on comments from: AzureAD#3064
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
var kwp = key.CryptoProviderFactory.CreateKeyWrapProviderForUnwrap();
'kwp' becomes out of scope and is not disposed.