Migrate to Lab Vault Cert for E2E Tests #7085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectormmg
requested review from
tnorling,
sameerag,
jo-arroyo,
lalimasharda,
peterzenz,
bgavrilMS,
Robbie-Microsoft and
konstantin-msft
as code owners
hectormmg
changed the title
.pipelines/3p-e2e.yml
Outdated
| DEBIAN_FRONTEND: noninteractive | ||
| ${{ if startsWith(variables['Build.SourceBranch'], 'refs/heads/') }}: | ||
| sourceBranchName: ${{ replace(variables['Build.SourceBranch'], 'refs/heads/', '') }} | ||
| ${{ if startsWith(variables['Build.SourceBranch'], 'refs/pull/') }}: |
There was a problem hiding this comment.
Should this be ${{ if startsWith(variables['System.PullRequest.SourceBranch'], 'refs/pull/') }}: instead?
jo-arroyo
reviewed
May 9, 2024
bgavrilMS
approved these changes
May 10, 2024
konstantin-msft
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
3p-e2e.ymlwhich defines a OneBranch pipeline to run 3P MSAL JS E2E tests to replace existing GitHub workflowsgen_env.shto use a new PowerShell script calledgen_env.ps1that creates and populates a .env file with E2E Test environment variables (Express session secret, ClientID, TenantID and the absolute path of the client certificate used to authenticate with the Lab App)e2e-test-utils/LabClientto use aCertificateCredentialinstead ofClientSecretCredentialb2c-user-flowsNode sample to use a SESSION_SECRET env variable instead of the AZURE_CLIENT_SECRET