Implemented functionality to skip the cache for MI when claims are provided #7207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbie-Microsoft
requested review from
sameerag,
tnorling,
hectormmg,
peterzenz,
bgavrilMS,
trwalke,
pmaytak,
gladjohn,
neha-bhargava,
rayluo and
Avery-Dunn
as code owners
Robbie-Microsoft
requested review from
jo-arroyo and
konstantin-msft
as code owners
bgavrilMS
reviewed
Jul 18, 2024
bgavrilMS
reviewed
Jul 18, 2024
change/@azure-msal-common-e4f59bc0-0846-4b3a-a6bd-b8a4829c5bff.json
Outdated
Show resolved
Hide resolved
|
@Robbie-Microsoft - pls continue to the work we discussed, but do not commit. This work hasn't been OK-ed yet by the MSI team. It will anyway be required for MSIv2. @gladjohn - please close the work items until we get confirmation. |
bgavrilMS
approved these changes
Aug 30, 2024
lib/msal-node/src/client/ManagedIdentitySources/BaseManagedIdentitySource.ts
Outdated
Show resolved
Hide resolved
Robbie-Microsoft
requested review from
lalimasharda and
shylasummers
as code owners
gladjohn
reviewed
Sep 26, 2024
| @@ -142,7 +142,10 @@ export class ManagedIdentityApplication { | |||
| correlationId: this.cryptoProvider.createNewGuid(), | |||
| }; | |||
|
|
|||
| if (managedIdentityRequest.forceRefresh) { | |||
| if ( | |||
| managedIdentityRequestParams.claims || | |||
There was a problem hiding this comment.
does msal js already have a way for app developers to provide this ?
There was a problem hiding this comment.
yes, but only per request basis. Hence, me adding the claims to the MI request params.
bgavrilMS
reviewed
Sep 27, 2024
| @@ -5,10 +5,12 @@ | |||
|
|
|||
| /** | |||
| * ManagedIdentityRequest | |||
| * - claims - a stringified claims request which will be used to determine whether or not the cache should be skipped | |||
There was a problem hiding this comment.
Suggested change
| * - claims - a stringified claims request which will be used to determine whether or not the cache should be skipped | |
| * - claims - in case a resource refuses to authenticate with a token (e.g. because the token has been revoked by the tenant admin), it may send a 401 response and a WWW-Authenticate header with a claims parameter. When this is configured, MSAL always requests a new token from the identity provider, and will add the claims to the request where this is supported. |
bgavrilMS
approved these changes
Sep 27, 2024
gladjohn
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-used functionality from ClientCredential flow.
This PR originally contained code to deprecate client assertion strings. That will now be a separate PR.