Mute no_server_response error when back navigation is detected #7342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstantin-msft
requested review from
sameerag,
tnorling,
hectormmg,
jo-arroyo,
peterzenz,
lalimasharda and
shylasummers
as code owners
konstantin-msft
changed the title
jo-arroyo
approved these changes
Sep 26, 2024
peterzenz
reviewed
Sep 27, 2024
| if (getNavigationType() !== "back_forward") { | ||
| parentMeasurement.event.errorCode = "no_server_response"; | ||
| } else { | ||
| this.logger.verbose( |
There was a problem hiding this comment.
Should we have some other errorcode we log here specifically for clicking the back button?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handleRedirectPromisethat instruments "no_server_response" error code when user navigates back to the app page from account picker UX.