Added E2E Test: Client Credentials with Certificate from Key Vault #7367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trwalke
reviewed
Oct 18, 2024
...ntials-with-cert-from-key-vault/test/client-credentials-with-cert-from-key-vault-aad.spec.ts
Show resolved
Hide resolved
trwalke
reviewed
Oct 18, 2024
...ntials-with-cert-from-key-vault/test/client-credentials-with-cert-from-key-vault-aad.spec.ts
Show resolved
Hide resolved
trwalke
reviewed
Oct 18, 2024
...ntials-with-cert-from-key-vault/test/client-credentials-with-cert-from-key-vault-aad.spec.ts
Show resolved
Hide resolved
trwalke
reviewed
Oct 18, 2024
...ntials-with-cert-from-key-vault/test/client-credentials-with-cert-from-key-vault-aad.spec.ts
Show resolved
Hide resolved
trwalke
requested changes
Oct 18, 2024
This is all handled in the unit tests. We just want to verify the token is received from the network request (via cert auth) here. |
Robbie-Microsoft
requested review from
trwalke and
a team
and removed request for
a team
trwalke
approved these changes
Oct 22, 2024
bgavrilMS
approved these changes
Oct 22, 2024
Robbie-Microsoft
added a commit
that referenced
this pull request
Nov 5, 2024
This was meant to be included in #7367. [Corresponding 1P PR](https://identitydivision.visualstudio.com/DefaultCollection/IDDP/_git/msal-javascript-1p/pullrequest/15266) You can click into the tests below and see that the new e2e tests completed successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a sample with a corresponding e2e test.
A follow up PR that converts the sample to TypeScript is located here.
Additionally, some potential follow up work would be to re-use some of the certificate transforming functionality introduced here and change the way developers pass in certificates.