Move correlationId to query string for /token calls #7385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnorling
requested review from
sameerag,
hectormmg,
jo-arroyo,
peterzenz,
Robbie-Microsoft,
konstantin-msft,
lalimasharda and
shylasummers
as code owners
tnorling
requested review from
bgavrilMS,
trwalke,
pmaytak,
gladjohn,
neha-bhargava,
rayluo and
Avery-Dunn
as code owners
github-actions
bot
added
documentation
lalimasharda
approved these changes
Oct 17, 2024
konstantin-msft
approved these changes
Oct 21, 2024
konstantin-msft
force-pushed
the
move-correlationId-to-query-string
branch
from
20233ca
to
9a786cb
Compare
sameerag
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eSTS only recognizes correlationId if it's in the QS or Headers of a request, we currently pass it in the body on /token calls and thus is ignored.
This PR moves correlationId to the QS of /token requests (moving to Headers would cause a CORS preflight request) to make correlating calls end to end easier.