-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform AOT check on repository #2845
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
reviewed
May 17, 2024
...t.Identity.Web.AotCompatibiliy.TestApp/Microsoft.Identity.Web.AotCompatibiliy.TestApp.csproj
Outdated
Show resolved
Hide resolved
...t.Identity.Web.AotCompatibiliy.TestApp/Microsoft.Identity.Web.AotCompatibiliy.TestApp.csproj
Outdated
Show resolved
Hide resolved
...t.Identity.Web.AotCompatibiliy.TestApp/Microsoft.Identity.Web.AotCompatibiliy.TestApp.csproj
Outdated
Show resolved
Hide resolved
...t.Identity.Web.AotCompatibiliy.TestApp/Microsoft.Identity.Web.AotCompatibiliy.TestApp.csproj
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Web.AotCompatibiliy.TestApp/Program.cs
Outdated
Show resolved
Hide resolved
SaurabhMSFT
commented
May 21, 2024
tests/Microsoft.Identity.Web.AotCompatibiliy.TestApp/Program.cs
Outdated
Show resolved
Hide resolved
...t.Identity.Web.AotCompatibiliy.TestApp/Microsoft.Identity.Web.AotCompatibiliy.TestApp.csproj
Outdated
Show resolved
Hide resolved
...t.Identity.Web.AotCompatibiliy.TestApp/Microsoft.Identity.Web.AotCompatibiliy.TestApp.csproj
Outdated
Show resolved
Hide resolved
...t.Identity.Web.AotCompatibiliy.TestApp/Microsoft.Identity.Web.AotCompatibiliy.TestApp.csproj
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
May 21, 2024
...t.Identity.Web.AotCompatibiliy.TestApp/Microsoft.Identity.Web.AotCompatibiliy.TestApp.csproj
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
May 21, 2024
...t.Identity.Web.AotCompatibiliy.TestApp/Microsoft.Identity.Web.AotCompatibiliy.TestApp.csproj
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
May 21, 2024
eerhardt
reviewed
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good. Just a couple minor comments. Once those are addressed I think this can be merged.
...t.Identity.Web.AotCompatibiliy.TestApp/Microsoft.Identity.Web.AotCompatibiliy.TestApp.csproj
Outdated
Show resolved
Hide resolved
...Identity.Web.AotCompatibility.TestApp/Microsoft.Identity.Web.AotCompatibility.TestApp.csproj
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
May 22, 2024
...Identity.Web.AotCompatibility.TestApp/Microsoft.Identity.Web.AotCompatibility.TestApp.csproj
Show resolved
Hide resolved
eerhardt
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this!
dualtagh
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Perform AOT check on repository
Added a script and yml file and a test app to perform AOT check on repository for every pull request. This script will notify us if a non AOT compatible change is added to the repo.