Revert: Warning Quality Check Build Task #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexholub113 Can you link to the pipeline that is now passing with this reverted? |
|
@alexholub113 I suspect you'll have to edit the pipeline for now to target your branch and ensure this fixes as expected I've shared more details in our internal channel. Once there's a passing pipeline run there I'll approve. In the fullness of time we should have that pipeline take a parameter for branch and then have IDWeb PRs run that pipeline as a merge gate |
|
To test this revert I created OneBranch PR. |
TimHannMSFT
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Thanks @alexholub113 !
Please create a PBI and assign to @kellyyangsong to re-add this check once it no longer breaks the onebranch PR build
|
Task was created |
alexholub113
deleted the
alexholub/revert-warning-quality-check-build-task
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since these changes cause errors in the pipeline it was decided to roll them back temporarily