Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert WaitForProcess in UI Tests #3189

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jmprieur
Copy link
Collaborator

@jmprieur jmprieur commented Jan 9, 2025

Revert WaitForProcess in UI Tests

Removes the call to "await currentProcess.WaitForExitAsync();" as the web APIs never terminate by themselves (they are a loop
that serves requests until the process is killed).

(Reverts this commit: a776bd9#diff-b97ec5511f2516fa159c3235ed616efa4594cbf8e25edcdd7555098ea830d9e6)

@jmprieur jmprieur requested a review from a team as a code owner January 9, 2025 04:25
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19 jennyf19 merged commit 230e1d5 into master Jan 9, 2025
3 of 4 checks passed
@jennyf19 jennyf19 deleted the jmprieur/revertWaitForProcessInUiTest branch January 9, 2025 04:28
Copy link

github-actions bot commented Jan 9, 2025

Summary

Summary
Generated on: 1/9/2025 - 4:41:15 AM
Coverage date: 1/9/2025 - 4:39:56 AM - 1/9/2025 - 4:41:01 AM
Parser: MultiReport (2x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants