Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved codebase for development #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improved codebase for development #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e835ee2
Ignored Vs code relative files
Anacron-sec Apr 14, 2019
305908f
Set firebase url using settings to ease development
Anacron-sec Apr 14, 2019
bfe3dd1
Add development tip to README.md
Anacron-sec Apr 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ settings.py
credentials_db.json
credentials_db_develop.json
Temp/
.vscode
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,9 @@ Per compilare il codice sulla propria macchina basterà installare le dipendenze
```bash
$ sudo pip3 install -r requirements.txt
```
Dopodichè sarà necessario andare a importare nel file ``UnicamEat.py`` il file ``settings_dist.py`` invece che il file ``settings.py``, andando a modificare secondo le prorpie scelte i parametri all'interno del file stesso.
Dopodichè sarà necessario andare a importare nel file ``UnicamEat.py`` il file ``settings_dist.py`` invece che il file ``settings.py``, andando a modificare secondo le proprie scelte i parametri all'interno del file stesso.

Un' alternativa, consigliata per chi volesse cimentarsi nel development, è quella di creare un file ``settings.py`` copiando il file ``settings_dist.py`` e compilare i vari campi. In questo modo si evita di creare dei commit nei quali il file ``UnicamEat.py`` utilizza il file di impostazioni errato.

Una volta installate le dipendenze e, modificate le varie impostazioni all'interno del file ``settings_dist.py``, basterà lanciare il seguente comando:
```bash
Expand Down
4 changes: 2 additions & 2 deletions firebase_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import firebase_admin
from firebase_admin import credentials, db

from settings import MENU_URL, Dirs
from settings import MENU_URL, FIREBASE_URL, Dirs


class Firebase:
Expand All @@ -27,7 +27,7 @@ def __init__(self, cert):

try:
firebase_admin.initialize_app(cred, {
'databaseURL': 'https://unicam-eat.firebaseio.com'
'databaseURL': FIREBASE_URL
})
except ValueError:
print(Fore.RED + "[ERROR] Il Database è probabilmente già aperto in un'altra istanza, "
Expand Down
1 change: 1 addition & 0 deletions settings_dist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
TOKEN = ''
BOT_NAME = "@UnicamEatBot"
MENU_URL = "" # Your URL of the menu in a .xml format
FIREBASE_URL = 'https://unicam-eat.firebaseio.com'


class Dirs:
Expand Down