Fixed inconsistencies for #1

.github/workflows/publish.yml

@@ -10,9 +10,9 @@ jobs:
       contents: read
       packages: write 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       # Setup .npmrc file to publish to GitHub Packages
-      - uses: actions/setup-node@v2
+      - uses: actions/setup-node@v3
         with:
           node-version: '14.x'
           registry-url: 'https://npm.pkg.github.com'
@@ -23,5 +23,3 @@ jobs:
       - run: yarn publish
         env:
           NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-

.github/workflows/test.yml

@@ -12,12 +12,11 @@ jobs:
       contents: read
       packages: read
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       # Setup .npmrc file to publish to GitHub Packages
-      - uses: actions/setup-node@v2
+      - uses: actions/setup-node@v3
         with:
           node-version: '14.x'
-          registry-url: 'https://npm.pkg.github.com'
           # Defaults to the user or organization that owns the workflow file
       - run: yarn
       - run: yarn build

.yarnrc.yml

@@ -0,0 +1 @@
+nodeLinker: node-modules

package.json

@@ -1,6 +1,6 @@
 {
-  "name": "@b-techbw/mllp",
-  "version": "3.1.0",
+  "name": "@i-tech-uw/mllp-server",
+  "version": "3.1.3",
   "description": "MLLP (HL7) implementation in Node.js",
   "main": "lib/mllp.js",
   "types": "lib/mllp.d.ts",
@@ -16,10 +16,10 @@
   },
   "author": "Piotr Mankowski [email protected]>",
   "repository": {
-    "url": "git://github.com/b-techbw/mllp.git"
+    "url": "git://github.com/i-tech-uw/mllp-server.git"
   },
   "bugs": {
-    "url": "https://github.com/b-techbw/mllp/issues"
+    "url": "https://github.com/i-tech-uw/mllp-server/issues"
   },
   "mocha": {
     "require": [

src/mllp.ts

@@ -1,3 +1,4 @@
+import { Socket } from 'dgram';
 import * as net from 'net'
 import { TypedEmitter } from 'tiny-typed-emitter';
 
@@ -35,6 +36,7 @@ export class MllpServer extends TypedEmitter<MllpEvents> {
     host: string
     logger: any
     server: net.Server
+    message: string;
 
     static readonly VT = String.fromCharCode(0x0b);
     static readonly FS = String.fromCharCode(0x1c);
@@ -45,33 +47,23 @@ export class MllpServer extends TypedEmitter<MllpEvents> {
 
         this.host = host || '127.0.0.1'
         this.port = port || 6969
-        this.logger = logger || console;
-
+        this.logger = logger || console
+        this.message = ''
         this.server = net.createServer(this.serverListener.bind(this))
-
     }
 
     private serverListener(sock: net.Socket) {
         this.logger.info('CONNECTED: ' + sock.remoteAddress + ':' + sock.remotePort);
 
         sock.on('data', (data: any) => {
-            let { msg, ack } = this.handleData(data.toString())
-
-            /**
-             * MLLP HL7 Event. Fired when a HL7 Message is received.
-             * @event MllpServer#hl7
-             * @type {string}
-             * @property {string} message string containing the HL7 Message (see example below)
-             * @example MSH|^~\&|XXXX|C|SOMELAB|SOMELAB|20080511103530||ORU^R01|Q335939501T337311002|P|2.3|||
-             */
-            this.emit('hl7', msg);
+            data = data.toString()
+            this.logger.info("DATA:\nfrom " + sock.remoteAddress + ':\n' + data.split("\r").join("\n"));
 
-            sock.write(MllpServer.VT + this.ackn(ack, "AA") + MllpServer.FS + MllpServer.CR);
+            this.handleData(data.toString(), sock)
         })
         sock.on('close', (data) => {
             this.logger.info('CLOSED: ' + sock.remoteAddress + ' ' + sock.remotePort);
         });
-
     }
 
     private ackn(data: any, ack_type: string): string {
@@ -99,24 +91,31 @@ export class MllpServer extends TypedEmitter<MllpEvents> {
         return result;
     }
 
-    private handleData(msg: string) {
-        let message: string = ''
-        let ackData: any
-
+    private handleData(msg: string, sock: net.Socket) {
         //strip separators
         if (msg.indexOf(MllpServer.VT) > -1) {
-            message = '';
+            this.message = '';
         }
 
-        message += msg.replace(MllpServer.VT, '');
+        this.message += msg.replace(MllpServer.VT, '');
 
         if (msg.indexOf(MllpServer.FS + MllpServer.CR) > -1) {
-            message = message.replace(MllpServer.FS + MllpServer.CR, '');
-            ackData = hl7.parseString(message);
-            this.logger.info("Message:\r\n" + message + "\r\n\r\n");
-        }
+            this.message = this.message.replace(MllpServer.FS + MllpServer.CR, '');
+            let ackData: any = hl7.parseString(this.message);
+            this.logger.info("Message:\r\n" + this.message + "\r\n\r\n");
+
+            /**
+             * MLLP HL7 Event. Fired when a full HL7 Message is received.
+             * @event MllpServer#hl7
+             * @type {string}
+             * @property {string} message string containing the HL7 Message (see example below)
+             * @example MSH|^~\&|XXXX|C|SOMELAB|SOMELAB|20080511103530||ORU^R01|Q335939501T337311002|P|2.3|||
+             */
+            this.emit('hl7', this.message);
+            let ack = this.ackn(ackData, "AA")
 
-        return { msg: message, ack: ackData };
+            sock.write(MllpServer.VT + ack + MllpServer.FS + MllpServer.CR);
+        }
     }
 
     send(receivingHost: string, receivingPort: number, hl7Data: any, callback: Function) {