Add covariance propagation / mapping via sampling #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoumjian
requested changes
Oct 16, 2023
| orbit_ids_idx | ||
| ] | ||
|
|
||
| ephemeris = Ephemeris.from_kwargs( |
There was a problem hiding this comment.
It seems like we are retyping this variable multiple times? First whatever comes back from pyoorb, then a 2D numpy array, and now our Ephemeris / VariantEphemeris classes. Can we split them out into separate variables? Especially from mutable to immutable.
There was a problem hiding this comment.
Done. Spit it into ephemeris_array_3D, ephemeris_array, ephemeris, and variant_ephemeris (last two being the qv tables) .
moeyensj
force-pushed
the
jm/variant-ephemeris
branch
2 times, most recently
from
5bd3584 to
9e91de2
Compare
moeyensj
force-pushed
the
jm/return-ephemeris
branch
from
46d1706 to
8f7d9a4
Compare
moeyensj
force-pushed
the
jm/variant-ephemeris
branch
from
9e91de2 to
892d076
Compare
…orbits and Propagator.generate_ephemeris
Remove variable shadowing in PYOORB._generate_ephemeris while we are at it Co-authored-by: Alec Koumjian <[email protected]>
moeyensj
force-pushed
the
jm/variant-ephemeris
branch
from
892d076 to
905b550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #81. Similar to propagating orbital covariances, this PR allows orbital covariances to be mapped to ephemerides via sampling.
For the time-being I have set the default method to monte-carlo, the sigma point code needs to be investigated for optimal parameter selection. There was an array shape bug that was fixed in d9dab91, that I think impacts the way the random draws were working.