Assume missing off-diagonal covariance values are zero #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moeyensj
force-pushed
the
jm/residual-covariance-fix
branch
from
79d20cf to
6d7c3cb
Compare
moeyensj
force-pushed
the
jm/residual-covariance-fix
branch
from
6d7c3cb to
16677be
Compare
…ying a cos(latitude) correction factor
moeyensj
force-pushed
the
jm/residual-covariance-fix
branch
from
16677be to
f984edb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, we might have covariance matrices that have only diagonal elements defined with the off-diagonal elements missing (represented as NaNs). Some input coordinates may represent datasets that do not explicitly calculate off-diagonal (covariance) values, but we still want to be able to calculate chi2 for those coordinates using the diagonal (variance) values. In these instances, this PR modifies the residuals code to assume those missing values are zero and emits a warning when this occurs.