Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace usages of copy_arrays with memmap for asdf>=3.1.0 #940

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

zacharyburnett
Copy link
Contributor

@zacharyburnett zacharyburnett commented Jul 18, 2024

Changes

follow-on to asdf-format/asdf#1797

Related Issues

Checks

  • updated CHANGELOG.md
  • updated tests/
  • updated doc/
  • update example/tutorial notebooks
  • update manifest file

@zacharyburnett zacharyburnett marked this pull request as ready for review July 18, 2024 19:33
@zacharyburnett zacharyburnett changed the title replace usages of copy_arrays with memmap replace usages of copy_arrays with memmap for asdf>=3.1.0 Jul 18, 2024
Copy link

github-actions bot commented Aug 5, 2024

Test Results

2 188 tests  ±0   2 187 ✅ ±0   1m 56s ⏱️ -1s
    1 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 034c041. ± Comparison against base commit 35f92d7.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.38%. Comparing base (5ad2929) to head (034c041).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
weldx/asdf/util.py 60.00% 2 Missing ⚠️
weldx/asdf/file.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
- Coverage   96.48%   96.38%   -0.11%     
==========================================
  Files          95       95              
  Lines        6293     6310      +17     
==========================================
+ Hits         6072     6082      +10     
- Misses        221      228       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CagtayFabry CagtayFabry self-requested a review August 5, 2024 11:14
@CagtayFabry CagtayFabry added ASDF everything ASDF related (python + schemas) deprecation function or dependency deprecations dependencies changes in package dependencies labels Aug 5, 2024
@CagtayFabry CagtayFabry merged commit 336c835 into BAMWelDX:master Aug 5, 2024
19 of 21 checks passed
@zacharyburnett zacharyburnett deleted the deprecate/copy_arrays branch August 6, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas) dependencies changes in package dependencies deprecation function or dependency deprecations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants