메인화면 식단 영역 최종 리뉴얼 및 QA 대응 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 16, 2024
Closed
ThirFir
approved these changes
Apr 16, 2024
| } | ||
|
|
||
| private fun updateMenu(list: List<Dining>, position: Int, arrangedList: List<Dining>) { | ||
| val menus = listOf( |
There was a problem hiding this comment.
TextView가 많아서 관리하는 데 조금 어려움이 있지 않을까 생각이 들어요. 식단 상세 페이지의 경우 하나의 텍스트 뷰에서 줄바꿈을 통해 식단을 구분하여 표시하고 있는데, 그런 비슷한 느낌으로 텍스트 뷰를 줄이면 코드 작성이 더 수월해질 수 있을 것 같아요.
There was a problem hiding this comment.
forEach로 한번에 접근하면 되서 어려움은 느끼지 못했었는데 공식문서에서도 이렇게 권장하는걸 보니 구조를 바꾸어야하긴 하겠네용 반영하겠습니다!
| } | ||
| } | ||
|
|
||
| fun updateDining(list: List<Dining>, position: Int) { |
There was a problem hiding this comment.
변수명을 list 대신 좀 더 명확한 것으로 사용한다면 다른 사람 입장에서 구분하기 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
작업사항
참고사항
구현 화면
(18시 01분 기준 - 에뮬레이터 직접 끈거에요 앱 터진거 아니에요)
2024-04-16.6.04.21.mov