[Feature] 내 상점 페이지 이벤트/공지 수정 삭제 #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature/business/store_detail # Conflicts: # business/src/main/java/in/koreatech/business/feature/store/EventScreen.kt # data/src/main/java/in/koreatech/koin/data/api/auth/OwnerAuthApi.kt # data/src/main/java/in/koreatech/koin/data/source/remote/OwnerRemoteDataSource.kt
# Conflicts: # business/src/main/java/in/koreatech/business/feature/store/EventScreen.kt # business/src/main/java/in/koreatech/business/feature/store/MyStoreDetailState.kt
Jokwanhee
reviewed
Jul 7, 2024
| @@ -116,7 +116,18 @@ object BusinessAuthNetworkModule { | |||
| ): Interceptor { | |||
| return Interceptor { chain: Interceptor.Chain -> | |||
| runBlocking { | |||
| val ownerAccessToken = tokenLocalDataSource.getOwnerAccessToken() ?: "" | |||
| val ownerAccessToken = | |||
| "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzM4NCJ9.eyJpZCI6NTU0OCwiZXhwIjoxNzE5ODg2Nzc4fQ.5LjbuPxi1G0aQoxtvWjB3ajpd28k6kjjCp4I199fkt3C8cRa40zxcjJwS91X0pSi" | |||
There was a problem hiding this comment.
access token 하드코딩으로 넣은 이유가 뭔가요? 테스트하다가 실수로 넣은건가요?
There was a problem hiding this comment.
절대로 토큰을 commit 하지 마세요. 시크릿 키 포함
business/src/main/java/in/koreatech/business/feature/store/AppBar.kt
Outdated
Show resolved
Hide resolved
business/src/main/java/in/koreatech/business/feature/store/OwnerStoreDialog.kt
Outdated
Show resolved
Hide resolved
business/src/main/java/in/koreatech/business/feature/store/storedetail/event/EventItem.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/in/koreatech/koin/domain/usecase/business/DeleteOwnerEventsUseCase.kt
Outdated
Show resolved
Hide resolved
business/src/main/java/in/koreatech/business/feature/store/storedetail/event/EventScreen.kt
Outdated
Show resolved
Hide resolved
yunjaena
requested changes
Jul 7, 2024
| @@ -116,7 +116,18 @@ object BusinessAuthNetworkModule { | |||
| ): Interceptor { | |||
| return Interceptor { chain: Interceptor.Chain -> | |||
| runBlocking { | |||
| val ownerAccessToken = tokenLocalDataSource.getOwnerAccessToken() ?: "" | |||
| val ownerAccessToken = | |||
| "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzM4NCJ9.eyJpZCI6NTU0OCwiZXhwIjoxNzE5ODg2Nzc4fQ.5LjbuPxi1G0aQoxtvWjB3ajpd28k6kjjCp4I199fkt3C8cRa40zxcjJwS91X0pSi" | |||
There was a problem hiding this comment.
절대로 토큰을 commit 하지 마세요. 시크릿 키 포함
business/src/main/java/in/koreatech/business/feature/store/storedetail/MyStoreDetailScreen.kt
Outdated
Show resolved
Hide resolved
…erStoreDialog.kt Co-authored-by: Jokwanhee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 상세내용
결과 화면