[Feature] 내 상점 수정 페이지 다중 이미지 업로드 #331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunjaena
requested changes
Jul 19, 2024
| var fileSize = 0L | ||
| val inputStream = context.contentResolver.openInputStream(it) | ||
| if (it.scheme.equals("content")) { | ||
| val cursor = context.contentResolver.query(it, null, null, null, null) |
There was a problem hiding this comment.
query하는 Main thread에서 작업하는게 무거울 수 있습니다. worker thread에서 작업하도록 변경해주세요 :)
There was a problem hiding this comment.
사진 관리하는 화면이 많으면 따로 클래스로 빼서 작업해보는것도 좋아보이네요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 상세내용
결과 화면