[Feature]가게 선택 다이얼로그 생성 #401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunjaena
requested changes
Oct 2, 2024
|
|
||
| @Preview | ||
| @Composable | ||
| fun PreviewMyStoreSelectDialog() { |
There was a problem hiding this comment.
Suggested change
| fun PreviewMyStoreSelectDialog() { | |
| private fun PreviewMyStoreSelectDialog() { |
| val isEventExpanded: List<Boolean> = List(storeEvent?.size ?: 0) { false }, | ||
| val isAllEventSelected: Boolean = false, | ||
| val isSelectedEvent: MutableList<Int> = mutableListOf(), | ||
| val isEditMode: Boolean = false | ||
| val isEditMode: Boolean = false, |
There was a problem hiding this comment.
Suggested change
| val isEditMode: Boolean = false, | |
| val isEditMode: Boolean = false |
| @@ -83,14 +78,20 @@ fun MyStoreDetailScreen( | |||
| val context = LocalContext.current | |||
|
|
|||
| LaunchedEffect(state.storeInfo) { | |||
| viewModel.initOwnerShopList() | |||
| viewModel.changeMyStoreInfo(storeId = state.storeId) | |||
There was a problem hiding this comment.
viewModel에서 변경할수있는 로직같습니다. 확인해주세요
yunjaena
requested changes
Oct 6, 2024
| ModifyInfoSideEffect.NavigateToMyStoreScreen -> { | ||
| storeInfoViewModel.modifyStoreInfo(state.storeInfo) | ||
| storeInfoViewModel.refreshStoreList() | ||
| onModifyButtonCLicked() |
There was a problem hiding this comment.
Suggested change
| onModifyButtonCLicked() | |
| onModifyButtonClicked() |
| @@ -279,7 +279,11 @@ fun ModifyInfoScreen( | |||
| when (it) { | |||
| ModifyInfoSideEffect.NavigateToBackScreen -> onBackClicked() | |||
| ModifyInfoSideEffect.NavigateToSettingOperatingTime -> onSettingOperatingClicked() | |||
| else -> {} | |||
| ModifyInfoSideEffect.NavigateToMyStoreScreen -> { | |||
| storeInfoViewModel.modifyStoreInfo(state.storeInfo) | |||
There was a problem hiding this comment.
modify가 완료가 되고 refresh를 해야되는게 아닌가요? (실패했을경우?)
There was a problem hiding this comment.
그래서 뷰모델에서
modifyInfoUseCase.invoke(
storeId,
storeDetailInfo,
).apply {
this ?: postSideEffect(ModifyInfoSideEffect.NavigateToMyStoreScreen)
}
이 코드를 통해 ErrorHandler가 null일 때 ModifyInfoSideEffect.NavigateToMyStoreScreen를 보내는 것으로 구현했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
상세 작업 내용
작업 결과물