[소그룹스터디] 경로를 static으로 변경 #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChoiWonBeen
reviewed
Aug 12, 2024
| @@ -43,7 +44,7 @@ function HotPost() { | |||
| hotArticleList.map((hotPost: HotPostResponse, index: number) => ( | |||
| <Link | |||
| className={styles.hotpost__content} | |||
| to={`/board/notice/${hotPost.id}`} | |||
| to={`${ROUTES.BOARD_NOTICE_DETAIL.replace(':id', String(hotPost.id))}`} | |||
There was a problem hiding this comment.
route를 함수로 바꿔쓰는건 어떻까용?
인터페이스가 꽤나 불편해보여용
Routes.BoardNoticeDetail({id: hotPost.id})
There was a problem hiding this comment.
구조 개편 완료했습니다. caeeac7
ChoiWonBeen
reviewed
Aug 16, 2024
src/static/routes.ts
Outdated
| AuthModifyInfo: '/auth/modifyinfo', | ||
| Review: { | ||
| path: 'review/:id', | ||
| general: (id: string) => `/review/${id}`, |
There was a problem hiding this comment.
2개 이상의 path를 쓰는 경우를 대비해서 객체로 받는건 어떨까욤
daepan
approved these changes
Aug 30, 2024
|
확장성 있게 변경했습니다~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
ScreenShot 📷
Test CheckList ✅
Precaution
✔️ Please check if the PR fulfills these requirements
developbranch unconditionally?main?yarn lint