[시간표] 시간 자동 조정 기능 #494
Merged
[시간표] 시간 자동 조정 기능 #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dooohun
approved these changes
Sep 23, 2024
Comment on lines
+62
to
+63
| transform: rotate(180deg); | ||
| transition: transform 0.3s ease; |
There was a problem hiding this comment.
애니메이션 대박이네요! 엄청 깔끔하고 좋은 것 같아요 👍
gpu 가속을 지원하는 css 속성들을 알고 사용하면 좋을 거 같아요! transform 속성, opacity, will-change(과도한 사용은 성능 저하를 일으킨다고 알려져 있음...)과 같은 css 속성을 사용하는게 성능상에 많은 도움이 된다고 합니다!
There was a problem hiding this comment.
오..! 혜준님의 아이디어를 보고 적용해봤습니다. 하하..! 유용한 정보 감사합니당~~!
Comment on lines
+367
to
+368
| <Listbox list={[...HOUR, { label: '24시', value: '24시' }]} value={time.endHour} onChange={handleLectureTimeByTime('endHour', index)} version="addLecture" /> | ||
| <Listbox list={time.endHour === '24시' ? [{ label: '00분', value: '00분' }] : MINUTE} value={time.endMinute} onChange={handleLectureTimeByTime('endMinute', index)} version="addLecture" /> |
There was a problem hiding this comment.
위에는 시작하는 시간이라 24시가 포함되지 않은 건가요? (궁금)
There was a problem hiding this comment.
맞습니다!! 정확하시군요!
Co-authored-by: dooohun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
24시 00분까지 선택 가능하게 했습니다.12:00인데 종료 시간을10:00로 선택하는 경우와 같이 올바르지 않은 시간을 선택하는 경우 자동으로 시간 조정이 되도록 했습니다. 올바르지 않은 시간을 선택하는 경우 선택한 시간에서 +1시간 혹은 -1시간을 하여 자동 조정해줍니다.예외의 경우
startTime을 23:30으로 선택했을 때endTime은 24:00으로 설정endTime을 09:00이나 09:30으로 선택하면startTime은 09:00로 설정ScreenShot 📷
버튼 내 글자 깨짐
드롭다운 downArrow 이미지 수정
시간 자동 조정
-.-.Chrome.2024-09-19.11-44-16.mp4
Test CheckList ✅
Precaution
✔️ Please check if the PR fulfills these requirements
developbranch unconditionally?main?yarn lint