-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[시간표] 삭제 되돌리기 기능 #510
Merged
Merged
[시간표] 삭제 되돌리기 기능 #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinGu-Jeong
reviewed
Sep 25, 2024
MinGu-Jeong
reviewed
Sep 25, 2024
src/pages/TimetablePage/components/TimetableList/TimetableSettingModal/index.tsx
Show resolved
Hide resolved
MinGu-Jeong
reviewed
Sep 25, 2024
MinGu-Jeong
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
api path 안 맞는 부분 수정했습니다.onSuccess
로 옮겼습니다.src/pages/TimetablePage/hooks/useDeleteTimetableFrame.ts
src/pages/TimetablePage/hooks/useTimetableV2Mutation.ts
또한, 현재는 강의 복구를 할 때 분반, 학과코드 등이 표시되지 않고 있고, 시간표 프레임도 복구할 때 이전 이름으로 복구되지 않는데 이는 api 수정 이후 잘 작동할 예정입니다.(api 수정 이후 한 번 더 확인하겠습니다.)--> 작동 잘 됩니다! 4ad645aScreenShot 📷
-.-.Chrome.2024-09-24.12-53-41.mp4
-.-.Chrome.2024-09-24.12-56-00.mp4
✔️ Please check if the PR fulfills these requirements
develop
branch unconditionally?main
?yarn lint