Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[시간표] 학기 삭제 api 연동 #531

Merged
merged 1 commit into from
Oct 3, 2024
Merged

[시간표] 학기 삭제 api 연동 #531

merged 1 commit into from
Oct 3, 2024

Conversation

Gwak-Seungju
Copy link
Contributor

What is this PR? 🔍

Changes 📝

  • 기존에는 시간표 프레임을 삭제하는 api를 이용해서 그 학기에 있는 모든 시간표 프레임을 삭제해서 학기 삭제를 구현했는데 백엔에서 모든 시간표 프레임을 삭제하는 api를 만들어 주셔서 그것을 이용하여 학기 삭제를 구현했습니다.

✔️ Please check if the PR fulfills these requirements

  • It's submitted to the correct branch, not the develop branch unconditionally?
  • If on a hotfix branch, ensure it targets main?
  • There are no warning message when you run yarn lint

@Gwak-Seungju Gwak-Seungju added 📬 API 서버 API 통신 👤 User 유저, 시간표 도메인 labels Oct 3, 2024
@Gwak-Seungju Gwak-Seungju self-assigned this Oct 3, 2024
@Gwak-Seungju Gwak-Seungju changed the title feat: 학기 삭제 api 연동 [시간표] 학기 삭제 api 연동 Oct 3, 2024
hyejun0228
hyejun0228 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@hyejun0228 hyejun0228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~! 👍

@Gwak-Seungju Gwak-Seungju merged commit 7870bc7 into develop Oct 3, 2024
3 checks passed
@github-actions github-actions bot deleted the feat/#530/delete-semester-api branch October 3, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyejun0228 hyejun0228 hyejun0228 approved these changes

@D0Dam D0Dam Awaiting requested review from D0Dam

Assignees

@Gwak-Seungju Gwak-Seungju

Labels
📬 API 서버 API 통신 👤 User 유저, 시간표 도메인
Projects
🎓 TEAM USER
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[시간표] 학기 삭제 api 연동
2 participants
@Gwak-Seungju @hyejun0228