[상점] 생협 운영 시간 추가 #536
Merged
[상점] 생협 운영 시간 추가 #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinGu-Jeong
reviewed
Oct 7, 2024
Comment on lines
+125
to
+134
| {filteredCampusInfo.slice(0, 1).map(({ id, name, opens }) => ( | ||
| <div className={styles['info-block']} key={id}> | ||
| <div className={styles['icon-wrapper']}> | ||
| {SHOP_ICON[name as keyof typeof SHOP_ICON]} | ||
| </div> | ||
| <div className={styles['info-description-container']}> | ||
| <div className={styles['info-title']}>{name}</div> | ||
| {opens.map(({ day_of_week, open_time, close_time }) => ( | ||
| <div className={styles['info-description']} key={`${id}-${day_of_week}`}>{`${day_of_week}: ${getFormattedShopTime(open_time, close_time)}`}</div> | ||
| ))} |
There was a problem hiding this comment.
아래 부분까지 3번 반복되는 로직같은데 별도의 컴포넌트로 분리해서 재사용해도 좋을 것 같단 생각이 들어요
There was a problem hiding this comment.
고민을 안해본건 아니였단 말이죠..
여기에서 밖에 안쓰는 로직이어서 분리를 해서 일부러 depth를 줄 필요가 있을까 싶었습니다!
한 번 분리해보고서 어떻게 읽히는지 확인해볼게요!
hyejun0228
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
ScreenShot 📷
Precaution
✔️ Please check if the PR fulfills these requirements
developbranch unconditionally?main?yarn lint