Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] 회원가입 API 변경사항 대응 #71

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Conversation

hanagertrudeKim
Copy link
Collaborator

[#70] 회원가입 API 변경사항 대응

대응 상세 내용

  • 회원가입 POST 기존 path user/register => user/student/register
  • identity 프로퍼티 삭제
  • gender request type number로 변경
  • 성별 선택시 0과 1로 나타나는 오류 수정
  • 에러별로 핸들링 할 수 있도록 변경

예) 이메일 중복일시 에러 메시지 변경
image

딱히 테스트할만한 koreatech 아이디가 없어서, 이메일 인증 로직까지는 체크하지 못했습니다.
이부분에 대한 테스트는 QA시점으로 넘기거나, 계정을 삭제하고 다시 인증해야할것같습니다.

Please check if the PR fulfills these requirements

  • It's submitted to develop branch, not the main branch
  • The commit message follows our guidelines
  • There are no warning message when you run yarn lint
  • Docs updated for breaking changes

Screenshot

@ChoiWonBeen ChoiWonBeen merged commit 2a32c76 into develop Jan 17, 2024
2 checks passed
@junghaesung79 junghaesung79 deleted the feature/#70 branch August 8, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants