feat: limit consumer status history

BEagle1984 · Mar 18, 2022 · f96dd9d · f96dd9d
1 parent 0a255b0
commit f96dd9d
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 3 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -1,6 +1,6 @@
 <Project>
   <PropertyGroup Label="Package information">
-    <BaseVersionSuffix>-beta.1</BaseVersionSuffix>
+    <BaseVersionSuffix>-beta.2</BaseVersionSuffix>
     <BaseVersion>3.6.1$(BaseVersionSuffix)</BaseVersion>
     <DatabasePackagesRevision>1</DatabasePackagesRevision>
     <DatabasePackagesVersionSuffix>$(BaseVersionSuffix)</DatabasePackagesVersionSuffix>

diff --git a/docs/releases.md b/docs/releases.md
@@ -9,6 +9,7 @@ uid: releases
 ### Fixes
 
 * Handle race condition in [BatchSequence](xref:Silverback.Messaging.Sequences.Batch.BatchSequence) with timeout
+* Limit consumer status history
 
 # Releases
 

diff --git a/src/Silverback.Integration/Messaging/Broker/ConsumerStatusInfo.cs b/src/Silverback.Integration/Messaging/Broker/ConsumerStatusInfo.cs
@@ -8,7 +8,9 @@ namespace Silverback.Messaging.Broker
 {
     internal sealed class ConsumerStatusInfo : IConsumerStatusInfo
     {
-        private readonly List<IConsumerStatusChange> _history = new();
+        private const int MaxHistorySize = 10;
+
+        private readonly LinkedList<IConsumerStatusChange> _history = new();
 
         public IReadOnlyCollection<IConsumerStatusChange> History => _history;
 
@@ -43,7 +45,11 @@ public void RecordConsumedMessage(IBrokerMessageIdentifier? brokerMessageIdentif
         private void ChangeStatus(ConsumerStatus status)
         {
             Status = status;
-            _history.Add(new ConsumerStatusChange(status));
+
+            if (_history.Count == MaxHistorySize)
+                _history.RemoveFirst();
+
+            _history.AddLast(new ConsumerStatusChange(status));
         }
     }
 }
diff --git a/tests/Silverback.Integration.Tests/Messaging/Broker/ConsumerStatusInfoFixture.cs b/tests/Silverback.Integration.Tests/Messaging/Broker/ConsumerStatusInfoFixture.cs
@@ -0,0 +1,33 @@
+// Copyright (c) 2020 Sergio Aquilini
+// This code is licensed under MIT license (see LICENSE file for details)
+
+using System.Linq;
+using FluentAssertions;
+using Silverback.Messaging.Broker;
+using Xunit;
+
+namespace Silverback.Tests.Integration.Messaging.Broker
+{
+    public class ConsumerStatusInfoFixture
+    {
+        [Fact]
+        public void History_ShouldBeRolledOver()
+        {
+            ConsumerStatusInfo statusInfo = new();
+
+            for (int i = 0; i < 5; i++)
+            {
+                statusInfo.SetConnected();
+                statusInfo.SetDisconnected();
+            }
+
+            statusInfo.History.Should().HaveCount(10);
+            statusInfo.History.First().Status.Should().Be(ConsumerStatus.Connected);
+
+            statusInfo.SetConnected();
+
+            statusInfo.History.Should().HaveCount(10);
+            statusInfo.History.First().Status.Should().Be(ConsumerStatus.Disconnected);
+        }
+    }
+}