Add BoxMapping for display mesh #710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #709
Adds box mapping to display mesh. This ensures textures are displayed on meshes - in particular critical for when a RenderGeometry with an assigned Texture with a bitmap is returned.
This could potentially be improved/expanded upon by changing the texture mapping method, but this simple box mapping seem to work decently well and be a good first step.
I tried also to use the
CreateCustomMeshMapping, providing the mesh, but that gave worse results, in particular for vertical faces that got the texture displayed as stripes of the value applicable to a particular x,y coordinate.Test files
Changelog
Additional comments