quick fix for positionInViewFilterGroup (twentyhq#9223)

fix 9206 In the future, we should have a look at the column naming "positionInViewFilterGroup" because it breaks the SQL queries in `record-position-query.factory.ts` for viewFilter tablenames
BOHEUS · Dec 24, 2024 · 801bf7c · 801bf7c
1 parent b52c23b
commit 801bf7c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/.../api/graphql/workspace-query-runner/factories/__tests__/query-runner-args.factory.spec.ts b/.../api/graphql/workspace-query-runner/factories/__tests__/query-runner-args.factory.spec.ts
@@ -22,34 +22,34 @@ describe('QueryRunnerArgsFactory', () => {
         {
           type: FieldMetadataType.POSITION,
           isCustom: true,
-          nameSingular: 'position',
+          name: 'position',
         },
         {
           type: FieldMetadataType.NUMBER,
           isCustom: true,
-          nameSingular: 'testNumber',
+          name: 'testNumber',
         },
         {
           type: FieldMetadataType.TEXT,
           isCustom: true,
-          nameSingular: 'otherField',
+          name: 'otherField',
         },
       ],
       fieldsByName: {
         position: {
           type: FieldMetadataType.POSITION,
           isCustom: true,
-          nameSingular: 'position',
+          name: 'position',
         },
         testNumber: {
           type: FieldMetadataType.NUMBER,
           isCustom: true,
-          nameSingular: 'testNumber',
+          name: 'testNumber',
         },
         otherField: {
           type: FieldMetadataType.TEXT,
           isCustom: true,
-          nameSingular: 'otherField',
+          name: 'otherField',
         },
       } as unknown as FieldMetadataMap,
     },

diff --git a/...rver/src/engine/api/graphql/workspace-query-runner/factories/query-runner-args.factory.ts b/...rver/src/engine/api/graphql/workspace-query-runner/factories/query-runner-args.factory.ts
@@ -40,7 +40,9 @@ export class QueryRunnerArgsFactory {
 
     const shouldBackfillPosition =
       options.objectMetadataItemWithFieldMaps.fields.some(
-        (field) => field.type === FieldMetadataType.POSITION,
+        (field) =>
+          field.type === FieldMetadataType.POSITION &&
+          field.name === 'position',
       );
 
     switch (resolverArgsType) {