-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add postgres config variables #21
Conversation
In GitLab by @LuiggiTenorioK on May 6, 2024, 16:05 @dbeltrankyl @kinow can we make a release in Pypi of these changes in order to be used along with the changes done in https://earth.bsc.es/gitlab/es/autosubmit/-/merge_requests/426 ? |
In GitLab by @kinow on May 6, 2024, 17:24 Maybe we can test these changes from the branch, and then review and merge everything once we've tested the changes? Even though this one looks harmless.. |
In GitLab by @dbeltrankyl on May 7, 2024, 09:44 I think we can merge this; it won't affect the current code. I'll approve it. Feel free to merge it or wait until Bruno's approval. |
In GitLab by @dbeltrankyl on May 7, 2024, 09:47 Btw, do you need this for development? @LuiggiTenorioK In my setup, I have both the autosubmit and autosubmitconfigparser in my pycharm project, So I don't need to push a new version while I'm developing; I just upload the autosubmitconfigparser when someone starts to review my merge. In that manner, I avoid uploading multiple ASconfigparser versions that need review and/or may be discarded at the end of the development. (though in this case, I find it unlikely ) |
In GitLab by @dbeltrankyl on May 7, 2024, 09:49 approved this merge request |
In GitLab by @LuiggiTenorioK on May 7, 2024, 09:54
Not really, I have a development version of these changes in my project too. But pushing a new version of the config parser will be needed to push the new Autosubmit version (4.2.0) that will support Postgres and test it. I think that once the 4.2.0 version is near to being released/tested I'll merge this. |
In GitLab by @LuiggiTenorioK on May 16, 2024, 13:38 @dbeltrankyl I'm merging these changes to main. Please, tell me when you release it to Pypi so I can update the dependencies of the EDITO version of Autosubmit and API |
In GitLab by @LuiggiTenorioK on May 16, 2024, 13:38 mentioned in commit dcf4bc1 |
In GitLab by @dbeltrankyl on May 16, 2024, 14:33 Hello @LuiggiTenorioK , I'll merge also the as_misc stuff I commented in the meeting, so maybe tomorrow if I finish the migrate command and all works as expected |
In GitLab by @LuiggiTenorioK on Apr 30, 2024, 16:46
Add the following config:
Issue: #7