Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgres config variables #21

Closed
wants to merge 1 commit into from
Closed

Conversation

LuiggiTenorioK
Copy link
Member

In GitLab by @LuiggiTenorioK on Apr 30, 2024, 16:46

Add the following config:

[database]
backend = postgres
connection_url = postgresql://myuser:mysecretpassword@localhost:5432/autosubmit

Issue: #7

@LuiggiTenorioK LuiggiTenorioK self-assigned this Oct 22, 2024
@LuiggiTenorioK
Copy link
Member Author

In GitLab by @LuiggiTenorioK on May 6, 2024, 16:05

@dbeltrankyl @kinow can we make a release in Pypi of these changes in order to be used along with the changes done in https://earth.bsc.es/gitlab/es/autosubmit/-/merge_requests/426 ?

@LuiggiTenorioK
Copy link
Member Author

In GitLab by @kinow on May 6, 2024, 17:24

Maybe we can test these changes from the branch, and then review and merge everything once we've tested the changes? Even though this one looks harmless..

@LuiggiTenorioK
Copy link
Member Author

In GitLab by @dbeltrankyl on May 7, 2024, 09:44

I think we can merge this; it won't affect the current code.

I'll approve it. Feel free to merge it or wait until Bruno's approval.

@LuiggiTenorioK
Copy link
Member Author

In GitLab by @dbeltrankyl on May 7, 2024, 09:47

Btw, do you need this for development? @LuiggiTenorioK

In my setup, I have both the autosubmit and autosubmitconfigparser in my pycharm project, So I don't need to push a new version while I'm developing;

I just upload the autosubmitconfigparser when someone starts to review my merge. In that manner, I avoid uploading multiple ASconfigparser versions that need review and/or may be discarded at the end of the development. (though in this case, I find it unlikely )

@LuiggiTenorioK
Copy link
Member Author

In GitLab by @dbeltrankyl on May 7, 2024, 09:49

approved this merge request

@LuiggiTenorioK
Copy link
Member Author

In GitLab by @LuiggiTenorioK on May 7, 2024, 09:54

Btw, do you need this for development?

Not really, I have a development version of these changes in my project too. But pushing a new version of the config parser will be needed to push the new Autosubmit version (4.2.0) that will support Postgres and test it.

I think that once the 4.2.0 version is near to being released/tested I'll merge this.

@LuiggiTenorioK
Copy link
Member Author

In GitLab by @LuiggiTenorioK on May 16, 2024, 13:38

@dbeltrankyl I'm merging these changes to main. Please, tell me when you release it to Pypi so I can update the dependencies of the EDITO version of Autosubmit and API

@LuiggiTenorioK
Copy link
Member Author

In GitLab by @LuiggiTenorioK on May 16, 2024, 13:38

mentioned in commit dcf4bc1

@LuiggiTenorioK
Copy link
Member Author

In GitLab by @dbeltrankyl on May 16, 2024, 14:33

Hello @LuiggiTenorioK ,

I'll merge also the as_misc stuff I commented in the meeting, so maybe tomorrow if I finish the migrate command and all works as expected

@LuiggiTenorioK LuiggiTenorioK deleted the postgres-config branch October 22, 2024 08:28
@LuiggiTenorioK LuiggiTenorioK restored the postgres-config branch October 22, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant