Draft: re-added notify_on

[kinow]

In GitLab by @dbeltrankyl on Dec 10, 2024, 14:55

This adds again the notify_on attribute.

JOB:
 NOTIFY_ON:
   - RUNNING
   - COMPLETED

Also the

mail:

 to: 
   - mail_1

expects a yaml_list

#1484 , #1468

TODO:

• test in bschubs when working, or any other automail.
• docs
• add pytests if confirmed this is enough

I believe the automail of BSC can't be tested outside the ibsc

[kinow]

In GitLab by @dbeltrankyl on Dec 10, 2024, 14:57

added 2 commits

• 38b7407 - re-added notify_on
• 99c00dc - changed default value to []

Compare with previous version

[kinow]

In GitLab by @dbeltrankyl on Dec 10, 2024, 15:07

marked this merge request as draft

[kinow]

In GitLab by @dbeltrankyl on Dec 10, 2024, 15:55

Tested on the bschubs

Autosubmit notification
-------------------------

Experiment id:  a826 

Job name: a826_LOCAL_SETUP 

The job status has changed from: SUBMITTED to COMPLETED 




INFO: This message was auto generated by Autosubmit, remember that you can disable these messages on Autosubmit config file. 

Mail recieved

[kinow]

In GitLab by @dbeltrankyl on Dec 10, 2024, 15:57

marked the checklist item test in bschubs when working, or any other automail. as completed

[kinow]

In GitLab by @dbeltrankyl on Dec 11, 2024, 15:32

Requires BSC-ES/autosubmit-config-parser#58 ( and update autosubmitconfigparser)

[kinow]

In GitLab by @dbeltrankyl on Dec 11, 2024, 15:32

marked the checklist item add pytests if confirmed this is enough as completed

[kinow]

In GitLab by @dbeltrankyl on Dec 11, 2024, 15:47

added 1 commit

• 5888664 - Added test to check attr value ( notify_on for now)

Compare with previous version

[kinow]

In GitLab by @dbeltrankyl on Dec 11, 2024, 15:50

added 1 commit

• 394e726 - Update doc

Compare with previous version

[kinow]

In GitLab by @dbeltrankyl on Dec 11, 2024, 15:51

Ready to review

• Added a pytest in autosubmit code to check the value of the job.notify_on attribute ( made it general to add all the attributes eventually)
• Updated docs
• Updated as configparser version # the pipeline won't work until notify_on normalized autosubmit-config-parser#58 is merged

[kinow]

In GitLab by @dbeltrankyl on Dec 11, 2024, 15:51

@isimo00 you can review this one if you want ( also the configparser associated one )

[kinow]

In GitLab by @dbeltrankyl on Dec 11, 2024, 15:52

requested review from @isimo00

[kinow]

In GitLab by @dbeltrankyl on Dec 11, 2024, 15:54

There is also a change in the mail_to code.. but it is a in-line comment . We can do a similar merge for that variable. I think there are some issues already created for the mail_to #1472 #1435( not sure about this one).

I've updated the mail_to doc to reflect that it expects a list right now

[kinow]

In GitLab by @dbeltrankyl on Dec 11, 2024, 15:55

added 1 commit

• 066bc39 - Update doc for mail_to

Compare with previous version

[kinow]

In GitLab by @dbeltrankyl on Dec 11, 2024, 15:56

marked the checklist item docs as completed

[kinow]

In GitLab by @isimo00 on Dec 11, 2024, 16:11

All seems good, thank you @dbeltrankyl !

[kinow]

In GitLab by @isimo00 on Dec 11, 2024, 16:12

approved this merge request

[kinow]

In GitLab by @isimo00 on Dec 11, 2024, 16:14

Well, I see the pipeline failed but I see it's because of the configparser version requirement so it's all good. I assume you ran it locally and everything passed

[dbeltrankyl]

Rebased and squashed, waiting for the pipeline...

[dbeltrankyl]

I did the rebase wrongly and corrected it,.. running the pipeline...

[dbeltrankyl]

Success, merging

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.93%. Comparing base (1f5ded1) to head (a778714).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
autosubmit/notifications/mail_notifier.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2020      +/-   ##
==========================================
+ Coverage   48.90%   48.93%   +0.02%     
==========================================
  Files          72       72              
  Lines       17517    17525       +8     
  Branches     3408     3408              
==========================================
+ Hits         8567     8575       +8     
  Misses       8150     8150              
  Partials      800      800              

Flag	Coverage Δ
fast-tests	48.93% <88.88%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.