Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace KHR_materials_translucency with KHR_materials_diffuse_transmission #15001

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

sebavan
Copy link
Member

@sebavan sebavan commented Apr 17, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 17, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 17, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 17, 2024

@sebavan sebavan requested review from Popov72 and bghgary April 17, 2024 23:46
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 17, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15001/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 17, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 17, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15001/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bghgary
Copy link
Contributor

bghgary commented Apr 18, 2024

Should we add a visual test?

@sebavan sebavan enabled auto-merge April 18, 2024 01:45
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 18, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15001/merge/testResults/webgpuplaywright/index.html

@sebavan sebavan merged commit 6dc9fc2 into BabylonJS:master Apr 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants