Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PersonModal): margin style for certain breakpoints #130

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

louh
Copy link
Member

@louh louh commented Dec 3, 2024

On a person's modal, and on some viewport widths, contact/socials links look like this:

Screenshot 2024-12-03 at 12 49 03 AM

In this PR, make it do this instead:

Screenshot 2024-12-03 at 12 48 30 AM

(left margin removed in all links; right margin expanded; slight increase in line-height to account for line breaks.)

@louh louh requested a review from slifty December 3, 2024 05:55
Copy link
Member

@slifty slifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔺
🔺🔺

w00t!

@louh louh merged commit d685ffc into main Dec 3, 2024
1 check passed
@louh louh deleted the louh/person-modal-ui-fix branch December 3, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants