-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KTLN-571] Getting the Value of a Custom Property Defined in 'gradle.properties' in Kotlin #1077
base: master
Are you sure you want to change the base?
Conversation
<plugin> | ||
<groupId>org.apache.maven.plugins</groupId> | ||
<artifactId>maven-surefire-plugin</artifactId> | ||
<version>3.0.0-M7</version> | ||
<configuration> | ||
<environmentVariables> | ||
<CUSTOM_PROPERTY>CustomValue</CUSTOM_PROPERTY> | ||
<API_URL>https://api.example.com</API_URL> | ||
</environmentVariables> | ||
</configuration> | ||
</plugin> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is leftover, and is probably not needed anymore?
customProperty=CustomValue | ||
apiUrl=https://api.example.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally, properties should be all lowercase and period separated.
custom.property
api.url
retest this please |
@@ -70,7 +70,6 @@ | |||
</execution> | |||
</executions> | |||
</plugin> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason to change this file. Let's revert it.
Added unit tests