Discounts #33
Merged
Discounts #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| JBStored721Tier storage storedTier = _storedTierOf[msg.sender][tierId]; | ||
|
|
||
| // Parse the flags. | ||
| (,,,, bool cannotIncreaseDiscountPercent) = _unpackBools(storedTier.packedBools); |
There was a problem hiding this comment.
looks kinda crazy but in each of these unpack instances
( /* bool ignoredVar */, /* bool ignoredVar2 */, /* bool ignoredVar3 */, /* bool ignoredVar4 */, bool cannotIncreaseDiscountPercent) = _unpackBools(storedTier.packedBools);
is more readable and safe to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow tier's to have a discountPercent, tunable by the collection's owner iff the tier doesn't have a flag indicating that it can't increase the discount.
Limitations & risks
Are there any trade-off or new vulnarbility surface based on theses changes?
Check-list
Interactions
These changes will impact the following contracts:
Directly:
Indirectly: