Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy hook with salt for deterministic address #37

Merged
merged 11 commits into from
Oct 8, 2024
Merged

Conversation

mejango
Copy link
Contributor

@mejango mejango commented Sep 22, 2024

Description

deploy hook with salt for deterministic address

Limitations & risks

Are there any trade-off or new vulnarbility surface based on theses changes?

Check-list

  • Tests are covering the new feature
  • Code is natspec'd
  • Code is linted and formatted
  • I have run the test locally (and they pass)
  • I have rebased to the latest main commit (and tests still pass)

Interactions

These changes will impact the following contracts:

  • Directly:

  • Indirectly:

src/JB721TiersHookDeployer.sol Show resolved Hide resolved
src/JB721TiersHookProjectDeployer.sol Outdated Show resolved Hide resolved
@@ -114,7 +118,7 @@ contract JB721TiersHookProjectDeployer is JBPermissioned, IJB721TiersHookProject
});

// Deploy the hook.
hook = HOOK_DEPLOYER.deployHookFor(projectId, deployTiersHookConfig);
hook = HOOK_DEPLOYER.deployHookFor(projectId, deployTiersHookConfig, salt);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one here

src/JB721TiersHookProjectDeployer.sol Outdated Show resolved Hide resolved
@mejango mejango merged commit 88c3060 into main Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants