Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commission payment workflow overhaul #448

Merged
merged 22 commits into from
Jul 6, 2023
Merged

commission payment workflow overhaul #448

merged 22 commits into from
Jul 6, 2023

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Jun 27, 2023

Fixes: #428
Fixes: #424
Fixes: #422
Fixes: #446
Fixes: #425

This PR implements the new commission payments workflow, per the discussed redesign, module the Works feature, which is handled by #232. The $20 limit stuff will be handled by #452 instead of here.

  • New status box
  • Terms link in comm and request
  • Final Invoice button + menu
  • Release All Deposits + confirmation/verifications
  • Request Deposit + menu
  • Show receipt at-time-of-invoice for invoice comments
  • Show amount released so far as part of the summary
  • Display lock/blocked thumbnails for unlocked images for artists, too (to make it clear for them that it's still locked)
  • Get old tests passing
  • Clean up multi-currency commission nonsense, since commissions are only supposed to have one currency now?
  • Ask for tip automatically with the final invoice (not for deposits)

@coveralls
Copy link
Collaborator

coveralls commented Jun 27, 2023

Coverage Status

coverage: 45.822% (-0.06%) from 45.885% when pulling 3a60be3 on zkat/new-comms-workflow into 4d82b4f on main.

@zkat zkat force-pushed the zkat/new-comms-workflow branch from 1b237a3 to aaaec58 Compare July 4, 2023 01:56
@zkat zkat force-pushed the zkat/new-comms-workflow branch from aaaec58 to 1385896 Compare July 4, 2023 02:10
@zkat zkat marked this pull request as ready for review July 6, 2023 00:24
@zkat zkat merged commit 16854c3 into main Jul 6, 2023
@zkat zkat deleted the zkat/new-comms-workflow branch July 6, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants