Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design Polish #697

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Design Polish #697

wants to merge 2 commits into from

Conversation

skullbunnygalaxy
Copy link
Contributor

@coveralls
Copy link
Collaborator

coveralls commented Aug 31, 2023 •
edited
Loading

Coverage Status

coverage: 45.268%. remained the same when pulling f9aa7d5 on sbg/designpolish into a1d7dbb on main.

@rjt-rockx
Copy link
Contributor

We should use the ring class wherever possible
Both outline and ring (which uses box-shadow) don't affect layout or size, while border does
and outline doesn't respect border-radius properly on safari iirc

@zkat zkat added the polish general quality improvements label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
polish general quality improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skullbunnygalaxy @coveralls @rjt-rockx @zkat