Merge pull request #7 from Banuba/fix/makeup-applying-issues

Fix makeup features applying
Banuba · Nov 8, 2023 · 8feea38 · 8feea38
2 parents a45aeb5 + 465379e
commit 8feea38
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/features/index.js b/src/features/index.js
@@ -101,18 +101,18 @@ export default {
           if (parameter.value === initValue) continue
 
           if (name.includes("shine")) {
-            if (shine.push(parameter) === 1)
+            if (shine.push(name) === 1)
               features.push({
                 group: "Lipstick",
                 name: "Shine",
-                clear: () => shine.forEach((parameter) => lipstickParams.reset(parameter.name)),
+                clear: () => shine.forEach((name) => lipstickParams.reset(name)),
               })
           } else if (name.includes("glitter")) {
-            if (glitter.push(parameter) === 1)
+            if (glitter.push(name) === 1)
               features.push({
                 group: "Lipstick",
                 name: "Glitter",
-                clear: () => glitter.forEach((parameter) => lipstickParams.reset(parameter.name)),
+                clear: () => glitter.forEach((name) => lipstickParams.reset(name)),
               })
           } else {
             features.push({

diff --git a/src/settings/eyes.js b/src/settings/eyes.js
@@ -17,6 +17,7 @@ export default {
     reset() {
       this.brows.reset()
       this.eyes.reset()
+      this.eyelashes.reset()
       this.makeup.reset()
     },
   },

diff --git a/src/settings/lipstick.js b/src/settings/lipstick.js
@@ -47,7 +47,7 @@ export default {
         :title="parameter.title"
         :value="parameter.value"
         @input="params.update({ [name]: { value: $event } })"
-        :max="['brightness', 'saturation'].includes(name) ? 2 : 1"
+        :max="['brightness', 'saturation', 'glitterIntensity', 'glitterBleeding', 'glitterGrain'].includes(name) ? 2 : 1"
       />
     </bnb-setting>
   `,