Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#136: Writing error logs to an ILogger instead of Console, adding an event for Unsupported Events, and other fixes #137

Closed
wants to merge 7 commits into from
Closed

#136: Writing error logs to an ILogger instead of Console, adding an event for Unsupported Events, and other fixes #137

wants to merge 7 commits into from

Conversation

DrEsteban
Copy link

@DrEsteban DrEsteban commented May 13, 2024 •
edited
Loading

This contains a fix for the issues described in #136

It also contains:

  • Fixes for deserialization issues in MediaInputStatus
  • Actually allowing OBSVideoSettings to be updated via the API, by removing internal from the setters
  • Build enhancements

@DrEsteban DrEsteban changed the title #136: Writing error logs to an ILogger instead of Console, and adding an event for Unsupported Events #136: Writing error logs to an ILogger instead of Console, adding an event for Unsupported Events, and other fixes May 21, 2024
@DrEsteban
Copy link
Author

I've recreated this PR as #140

Because I wanted to re-host it in a PullRequest branch in my fork rather than master, so it isn't constantly getting updated 🙂

@DrEsteban DrEsteban closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DrEsteban