Implemented high-volume events, dynamic reidentify, new event protocol #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarRaider
requested changes
Sep 1, 2022
|
Sorry don't have time now to fix the conflicts, maybe tomorrow or next week |
dedmen
force-pushed
the
patch-NewEvents
branch
2 times, most recently
from
78e9155
to
d8f7492
Compare
dedmen
force-pushed
the
patch-NewEvents
branch
from
d8f7492
to
dedfcdc
Compare
|
Okey here we go, that should be it. |
|
I'm interested in this feature, any updates? |
|
I was planning on adding it a while back but there are some uncomplete ("Todo") sections in the identify section as well as breaking backwards compatibility for the events that prevented me from pushing it. |
|
Hi! I'm trying to implement this feature on my app in C#. I'm add the event subscription but I never receive any data of the volume of OBS. Are there any additional step to can receive this data? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented events for protocol v5 ("update-type" changes to "eventType" and event data is in "eventData" member)
Implemented InputVolumeMeters event as a example of a high-volume event that requires dynamic subscription (via Reidentify) for the event
By the way your discord link in readme isn't working.